Fix indentation #1541
Merged
Fix indentation #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do the other hosts also need this fix? |
|
No, not the indentation, they do not have the same oTel code. Should I copy it over so all the hosts have the same OTel code? |
brockallen
approved these changes
Apr 17, 2024
josephdecock
approved these changes
Apr 18, 2024
|
@AndersAbel check the build failures. there's a security issue in a dependency: /Users/runner/work/IdentityServer/IdentityServer/hosts/EntityFramework/Host.EntityFramework.csproj : error NU1902: Warning As Error: Package 'OpenTelemetry.Instrumentation.AspNetCore' 1.5.1-beta.1 has a known moderate severity vulnerability, GHSA-vh2m-22xx-q94f [/Users/runner/work/IdentityServer/IdentityServer/Duende.IdentityServer.sln] |
|
@brockallen The build failures is independent of this. I'll create another PR for the packages. |
- It fills up the console, not suitable to have enabled by default
AndersAbel
force-pushed
the
anders/indentation
branch
from
0fbadba to
b63a218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.